链表，在末尾插入 C++

2022-01-01 00:00:00 linked-list c++

我正在编写一个简单的函数来插入到 C++ 链表的末尾，但最后它只显示了第一个数据.我无法弄清楚出了什么问题.这是功能:

I was writing a simple function to insert at the end of a linked list on C++, but finally it only shows the first data. I can't figure what's wrong. This is the function:

void InsertAtEnd (node* &firstNode, string name){

        node* temp=firstNode;

        while(temp!=NULL) temp=temp->next;

            temp = new node;
        temp->data=name;
        temp->next=NULL;

        if(firstNode==NULL) firstNode=temp;

}

推荐答案

你写的是:

  • 如果 firstNode 为空，它被替换为单个节点 temp没有下一个节点(没有人的 next 是 temp)

  • if firstNode is null, it's replaced with the single node temp which has no next node (and nobody's next is temp)

否则，如果 firstNode 不为 null，则什么都不会发生，除了 temp节点被分配和泄漏.

Else, if firstNode is not null, nothing happens, except that the temp node is allocated and leaked.

下面是更正确的代码:

void insertAtEnd(node* &first, string name) {
    // create node
    node* temp = new node;
    temp->data = name;
    temp->next = NULL;

    if(!first) { // empty list becomes the new node
        first = temp;
        return;
    } else { // find last and link the new node
        node* last = first;
        while(last->next) last=last->next;
        last->next = temp;
    }
}

另外，我建议向 node 添加一个构造函数:

Also, I would suggest adding a constructor to node:

struct node {
    std::string data;
    node* next;
    node(const std::string & val, node* n = 0) : data(val), next(n) {}
    node(node* n = 0) : next(n) {}
};

它使您能够像这样创建 temp 节点:

Which enables you to create the temp node like this:

node* temp = new node(name);

相关文章